Gear driven intake - #153
Merged
Merged
Conversation
Changed intake extension constants and Intake roller constants to fit the new intake. Some things need to be changed. Removed intake fast and made all intake roller speeds 12 volts
codeNinja-1
requested changes
Jul 15, 2026
codeNinja-1
left a comment
codeNinja-1
left a comment
Member
There was a problem hiding this comment.
Many changes look good, though there are a few issues in IntakeRollers. I didn't check the command logic around agitation. Also something went wrong with the first comment in this review, so just ignore it.
only agitates when not intaking when shooting to hub
scotch-tape
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed intake extension constants and Intake roller constants to fit the new intake. Some things need to be changed.
Removed intake fast and made all intake roller speeds 12 volts