Skip to content

Resolve ESLint and TypeScript build errors - #175

Open
tebberen wants to merge 1 commit into
farmcaster-frontend-skeletonfrom
fix/lint-and-typescript-errors-13068802251746954631
Open

Resolve ESLint and TypeScript build errors#175
tebberen wants to merge 1 commit into
farmcaster-frontend-skeletonfrom
fix/lint-and-typescript-errors-13068802251746954631

Conversation

@tebberen

@tebberen tebberen commented May 8, 2026

Copy link
Copy Markdown
Owner

This PR fixes strict ESLint and TypeScript errors that were preventing the production build from completing.

Key changes:

  • Unescaped Entities: All single quotes in JSX text have been escaped with ' in src/app/api/og/route.tsx, src/components/FavoriteReminder.tsx, and src/components/OnboardingModal.tsx.
  • Type Safety: Replaced any types with proper interfaces (FarcasterUser, HistoryItem) or unknown in src/components/HomeClient.tsx and src/app/api/og/route.tsx. This includes adding proper types for historyData, farcasterUser, and specific casting for transaction result IDs.
  • Cleanup: Removed unused variables chainName and mappedName from src/app/share/[network]/page.tsx, and unused imports/variables like useDisconnect and clsx.
  • Next.js Optimization: Replaced the profile <img> tag with the <Image /> component in HomeClient.tsx. Added a wildcard remotePatterns configuration in next.config.mjs to support profile images from various sources (like Farcaster PFP URLs).

The build now completes successfully (npm run build passes).


PR created automatically by Jules for task 13068802251746954631 started by @tebberen

- Escape single quotes in JSX for OnboardingModal, FavoriteReminder, and OG route.
- Replace 'any' types with proper interfaces (FarcasterUser, HistoryItem) or 'unknown'.
- Remove unused variables and imports in HomeClient and share/[network] page.
- Optimize profile image using Next.js Image component and update next.config.mjs for remote patterns.
- Ensure build succeeds for Vercel deployment.

Co-authored-by: tebberen <142526344+tebberen@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented May 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
farmcaster Ready Ready Preview, Comment May 8, 2026 9:50am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant