Coupling::stretch_with_identities: validate coupling_positions bounds - #272
Merged
Merged
Conversation
Raise a descriptive std::invalid_argument instead of segfaulting on out-of-range or empty coupling_positions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
LudwigZw
force-pushed
the
swi_error_messages
branch
from
September 8, 2026 15:00
56049b7 to
9e8ab76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coupling::stretch_with_identitiesindexedall_siteswith values takendirectly from the caller-supplied
coupling_positions, using uncheckedoperator[]. Out-of-range, negative, or (in the degenerate zero-tensorcase) empty
coupling_positionscaused a segfault instead of a Python-sideexception. This adds explicit validation so misuse fails with a clear
ValueErrorinstead.What the two new checks do
coupling_positions[i]must satisfy0 <= coupling_positions[i] < len(all_sites), since each one indexes intoall_sites. Violating this now raises:`coupling_positions[i]` = <value> is out of range for `all_sites` of length <n>coupling_positions(and thusfactorization) must benon-empty before taking
.front()/.back(), which are undefinedbehavior on an empty vector. Violating this now raises:
`coupling_positions` is empty; a `Coupling` with no factorization tensors cannot be stretchedTest plan
coupling_positionsbefore the fixValueErrorcleanly after the fixstretch_with_identitiestests intests/python_tests/models/test_couplings.pystill pass