fix(ci): satisfy Rust 1.98 byte-chunk lint - #12
Merged
GiggleLiu merged 1 commit intoAug 29, 2026
Conversation
GiggleLiu
force-pushed
the
codex/update-cubecl-complex-cast-pin
branch
from
August 29, 2026 15:51
313bd26 to
68b4038
Compare
GiggleLiu
force-pushed
the
codex/update-cubecl-complex-cast-pin
branch
from
August 29, 2026 15:51
68b4038 to
d256d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation
cargo xtask check lintfails on Rust 1.98 inread_host_datafor both F32 and I32 data:CubeK runs Clippy with
--deny warnings, so this warning blocks CI.Root cause
Both decoding loops split a byte buffer into four-byte slices with
chunks_exact(4), then convert each slice to[u8; 4]withtry_into().unwrap().The chunk size is known at compile time, and each buffer is allocated as
elem_count * size_of::<T>()beforeread_exactfills it. There cannot be a remainder. Rust 1.98 Clippy therefore flags the fallible slice conversion and asks foras_chunks::<4>().Fix
Use
buf.as_chunks::<4>().0and pass each[u8; 4]directly tofrom_le_bytes.This preserves the decoding behavior, removes the unnecessary conversion and
unwrap, and leaves the CubeCL dependency pin unchanged.Validation
cargo fmt --all -- --checkcargo test -p t4a-cubek-test-utils --lib round_trip(3 passed)cargo xtask check lint