discoveryengine: add list resources - #1386
Merged
Conversation
[upstream:4246b3331552b1d13ca63256e93a55d474ee98a0] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit Jul 28, 2026
246a398
into
terraform-google-modules:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Enables MMv1 list resource generation for Discovery Engine MMv1 resources by adding
generate_list_resource: trueto each eligible resource YAML.Also adds a new
list_filterYAML field (and template support) to allow list resources to append a static?filter=query parameter — used by the three engine resources which share the same API endpoint and are distinguished bysolutionType.Discovery Engine resources with list support added
google_discovery_engine_assistantgoogle_discovery_engine_chat_enginegoogle_discovery_engine_cmek_configgoogle_discovery_engine_controlgoogle_discovery_engine_data_storegoogle_discovery_engine_license_configgoogle_discovery_engine_recommendation_enginegoogle_discovery_engine_schemagoogle_discovery_engine_search_enginegoogle_discovery_engine_serving_configgoogle_discovery_engine_sitemapgoogle_discovery_engine_target_sitegoogle_discovery_engine_user_storeResources excluded
google_discovery_engine_data_connector— singleton resource (no list API)google_discovery_engine_acl_config— singleton resource (no list API)google_discovery_engine_widget_config— list API only exists atv1alpha; product base path isv1Notes
ChatEngine,SearchEngine, andRecommendationEngineall shareprojects.locations.collections.enginesas their API endpoint, differentiated bysolutionType. The newlist_filterfield generates?filter=solution_type=SOLUTION_TYPE_*on each list call so results are scoped to the correct engine type.:fetchendpoint returning asitemapsMetadatanested structure;collection_url_key: sitemapsMetadataand an updatedpost_readtemplate handle both the list and single-resource read contexts correctly.ControlandServingConfighavecollection_idwithdefault_value: default_collection. The list method template now seedsdefault_valueintoresourceDatawhen the caller omits the field, matching the resource schemaDefault:behaviour.Derived from GoogleCloudPlatform/magic-modules#18231