ces: fix app_version dependency in ces_deployment acceptance tests - #1389
Merged
Conversation
…18501) [upstream:bd4cab11e7e7e07fdd050dae6b01cb7e3566a2d9] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit Aug 4, 2026
6d79995
into
terraform-google-modules:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hardcoded
app_versiondependency inces_deploymentacceptance test sample templates (ces_deployment_basic.tf.tmpl,ces_deployment_full.tf.tmpl) and handwritten test (ces_deployment_test.go).Previously, the tests used a static string placeholder that did not belong to the dynamically created
google_ces_app.my-appresource, causing HTTP 400 errors. This change adds agoogle_ces_app_versionresource to the test configurations and setsapp_versiontogoogle_ces_app_version.my-app-version.idso that the full resource name is correctly referenced.Fixes hashicorp/terraform-provider-google#28082
Fixes hashicorp/terraform-provider-google#28074
Fixes hashicorp/terraform-provider-google#28101
Derived from GoogleCloudPlatform/magic-modules#18501