Update actions/setup-node action to v7 - #827
Conversation
|
To increment version on merge, please add one of |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c03b21e971
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v6 | ||
| uses: actions/setup-node@v7 |
There was a problem hiding this comment.
Keep registry auth available before Yarn install
This workflow sets registry-url here but doesn't provide NODE_AUTH_TOKEN until the final npm publish step, after yarn install has already run. The repo is pinned to Yarn Classic (packageManager: yarn@1.22.22), and the setup-node v7 breaking change says registry-url without NODE_AUTH_TOKEN can make legacy Yarn 1.x fail because the generated .npmrc references that env var; this blocks the RC job before lint/tests/build. Move/remove the registry setup for install-only steps or make NODE_AUTH_TOKEN available before the Yarn install.
Useful? React with 👍 / 👎.
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v6 | ||
| uses: actions/setup-node@v7 |
There was a problem hiding this comment.
Remove registry auth from the design install
This manual design workflow now uses setup-node@v7 with registry-url, then runs Yarn Classic with no NODE_AUTH_TOKEN anywhere in the job. Per the setup-node v7 breaking change, that combination can make legacy Yarn 1.x fail on the generated .npmrc before build-dictionary runs; since this workflow does not publish, dropping registry-url (or setting the token before install) avoids breaking the workflow.
Useful? React with 👍 / 👎.
15ce306 to
a183dc7
Compare
|
Not merging yet until the graphite comments are reviewed in more depth |
a4aa875 to
deaca6e
Compare
948937f to
a0b9c65
Compare
a0b9c65 to
73e032a
Compare
This PR contains the following updates:
v6→v7Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
actions/setup-node (actions/setup-node)
v7.0.0Compare Source
What's Changed
Enhancements:
Bug fixes:
mirrorTokeningetManifestif it's provided by @deiga in #1548Documentation updates:
Dependency update:
New Contributors
Full Changelog: actions/setup-node@v6...v7.0.0
v7Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.