feat: Dedupe and invalidate in-flight wallet address fetches - #79
Open
ashaltykou-innowise wants to merge 1 commit into
Open
feat: Dedupe and invalidate in-flight wallet address fetches#79ashaltykou-innowise wants to merge 1 commit into
ashaltykou-innowise wants to merge 1 commit into
Conversation
nulllpc
self-requested a review
August 3, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddressService.getAddresscalls for the same wallet/network/account so only one HRPC request runs.invalidateWallet/invalidateAll) so late responses after delete, lock, or reset do not write stale addresses or loading flags into the store.useWalletManager) and worklet teardown (WorkletLifecycleService), with unit coverage for dedupe and stale-write skipping.Test plan
AddressServiceunit tests (dedupe, invalidateWallet, invalidateAll, fresh fetch after invalidate)getAddressfor the same key results in a single HRPC call; different keys still fetch in parallel