Add copy-bundle forge command for proxy deployments - #619
Open
ehelms wants to merge 1 commit into
Open
Conversation
arvind4501
reviewed
Jul 3, 2026
| - "../../../src/vars/certificates.yml" | ||
| - "../../../src/vars/foreman.yml" | ||
| tasks: | ||
| - name: Fetch bundle |
Contributor
There was a problem hiding this comment.
Contributor
|
I tried similar thing in CI earlier 959a001#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R418-R419 , also i like what @evgeni mentioned about the approch of keeping things on system and then use it to deploy to any no of nodes |
ehelms
force-pushed
the
copy-bundle-command
branch
from
July 4, 2026 12:32
fbbc770 to
a1b33af
Compare
Extends the fetch-bundle forge command to also copy the certificate bundle to the proxy VM when one is in the inventory, and print the full deploy-proxy command with bundle path, FQDN, and oauth args. Also updates the certificates extract task to use remote_src since the bundle now resides on the target host. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ehelms
force-pushed
the
copy-bundle-command
branch
from
July 6, 2026 16:01
a1b33af to
81c28dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Deploying a proxy requires manually fetching the certificate bundle, copying it to the proxy VM, and then constructing the
deploy-proxycommand with the correct bundle path, FQDN, and oauth credentials. This is error-prone and requires looking up values from multiple sources.What are the changes introduced in this pull request?
forge fetch-bundleto copy the certificate bundle to the proxy VM at/root/<hostname>.tar.gzwhen a proxy is in the inventorydeploy-proxycommand with the correct--certificate-bundle,--foreman-fqdn,--oauth-consumer-key, and--oauth-consumer-secretargumentsextract.ymlto useremote_src: trueon theunarchivetask and removedelegate_to: localhoston the stat check, since the bundle now resides on the target host rather than the Ansible controllerHow to test this pull request
Steps to reproduce:
./foremanctl deploy --initial-admin-password=changeme --tuning development --add-feature foreman-proxy./foremanctl certificate-bundle proxy.example.com./forge fetch-bundle proxy.example.comdeploy-proxycommand with all required argumentsdeploy-proxycommand and verify the proxy deploys successfully./forge fetch-bundlestill works without a proxy VM in the inventoryChecklist