topology2: sdw-dmic-generic: raise TDFB bytes control max size#10970
Open
singalsu wants to merge 1 commit into
Open
topology2: sdw-dmic-generic: raise TDFB bytes control max size#10970singalsu wants to merge 1 commit into
singalsu wants to merge 1 commit into
Conversation
Setting the bytes control max inside the host-gateway-tdfb-drc-capture pipeline class had no effect: alsatplg leaves the widget control at the default 1024, so pushing a larger TDFB blob with sof-ctl failed. Move the max to the widget instantiation in sdw-dmic-generic.conf where it is honored, and keep the original 16384 headroom so the setting also covers larger beamformer blobs that may be added later. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Topology2 SoundWire DMIC enhanced capture controls so the TDFB bytes kcontrol has a larger maximum payload size where alsatplg actually honors it, preventing sof-ctl failures when uploading larger beamformer blobs.
Changes:
- Set
max 16384on the instantiatedCapture TDFB bytescontrol insdw-dmic-generic.conf. - Remove the ineffective
max 16384setting from thehost-gateway-tdfb-drc-capturepipeline class control definition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/topology/topology2/platform/intel/sdw-dmic-generic.conf | Raises the instantiated TDFB bytes control max to 16384 for SDW DMIC enhanced capture. |
| tools/topology/topology2/include/pipelines/cavs/host-gateway-tdfb-drc-capture.conf | Removes the non-functional class-level max setting for the TDFB bytes control. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the bytes control max inside the host-gateway-tdfb-drc-capture pipeline class had no effect: alsatplg leaves the widget control at the default 1024, so pushing a larger TDFB blob with sof-ctl failed.
Move the max to the widget instantiation in sdw-dmic-generic.conf where it is honored, and keep the original 16384 headroom so the setting also covers larger beamformer blobs that may be added later.