Skip to content

fix(ci): inherit secrets into the release workflow, serialize tag-on-main #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thetillhoff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): inherit secrets into the release workflow, serialize tag-on-main #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/tag-on-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ on:
branches:
- main

# Two merges in quick succession would otherwise run in parallel, both read the
# same `git describe` tag, and compute the same next version - one tag push wins
# and the other fails. Serialize instead, and never cancel: a cancelled run
# leaves a tag whose release never happened.
concurrency:
group: tag-on-main
cancel-in-progress: false

jobs:

determine-version:
Expand Down Expand Up @@ -81,6 +89,10 @@ jobs:
contents: write
packages: write
uses: ./.github/workflows/release-golang-executable-on-tag.yaml
# A called workflow receives no secrets unless they are passed, so
# HOMEBREW_TAP_ACCESS_TOKEN arrived empty in v3.0.5 and the tap update failed
# while the release itself succeeded.
secrets: inherit
with:
tag: ${{ needs.determine-version.outputs.NEW_VERSION }}
# These releases get no CHANGELOG entry, so the body carries the fixed
Expand Down