fix(ci): inherit secrets into the release workflow, serialize tag-on-main - #175
Merged
Merged
Conversation
…main Observed on temingo v3.0.5: release succeeded, run went red, because the homebrew tap step got an empty GH_TOKEN. A called workflow receives no secrets unless the caller passes them. Third instance of the workflow_call path diverging from `on: push: tags:`. Also adds a concurrency group. Two merges in quick succession would run in parallel, both read the same `git describe` tag and compute the same next version - one tag push wins, the other fails. Not cancel-in-progress: a cancelled run leaves a tag whose release never happened. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed on temingo v3.0.5: the release succeeded, the run went red, because the homebrew tap step got an empty
GH_TOKEN. A called workflow receives no secrets unless the caller passes them, sosecrets.HOMEBREW_TAP_ACCESS_TOKENresolves to empty on theworkflow_callpath. Third instance of that path diverging fromon: push: tags:(see #174 for the first two).secrets: inheritfixes it.Also adds a
concurrencygroup totag-on-main. Two renovate merges close together run in parallel, both read the samegit describeoutput, and compute the same next version - one tag push wins, the other fails.cancel-in-progress: false, since cancelling mid-run is how you end up with a tag whose release never happened.Counterpart: thetillhoff/temingo#100.