Tiny UCI loop: reuse the hoisted Searcher (packed build lost its killer table every move) - #142
Closed
thomasahle wants to merge 1 commit into
Closed
Tiny UCI loop: reuse the hoisted Searcher (packed build lost its killer table every move)#142thomasahle wants to merge 1 commit into
thomasahle wants to merge 1 commit into
Conversation
The module-level loop creates 'searcher = Searcher()' and then never uses it - each go constructed Searcher().search(hist), discarding tp_move (the killer/ordering table) between every move of a game. The full tools/uci.py interface reuses its Searcher correctly, so this only affected the packed build - which is exactly the TCEC 4k artifact, against opponents (pygone) that persist their tables all game. Found by literature-mining pygone's source for structural differences. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Good find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-token fix; see commit message. Affects only the packed/tiny-loop build (the lichess bot path was already correct). Smoke-tested: two-go session answers both bestmoves.
🤖 Generated with Claude Code