Refactor build_target to remove most of dependency resolution - #3565
Open
peterebden wants to merge 1 commit into
Open
Refactor build_target to remove most of dependency resolution#3565peterebden wants to merge 1 commit into
peterebden wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3562 (sort of, I know they have
gh pr stacknow but it seems to want me to do them all at once and my conception of this works incrementally).This refactors BuildTarget to remove the whole concept of "dependency resolution". It now only holds a sequence of BuildLabels, and turning those into BuildTargets and dealing with require/provide happens externally.
A bit of refactoring is needed since it can't provide the same interfaces any more;
Outputs()and similar functions actually have the biggest knock-on effect since they're called more widely.Have tried to make all the relevant test changes but there are still busted bits from #3562 which will get followed up in the next chapter.