Design update: ExpiryBadge and BaseBadge

[devmount]

What changed?

This PR aligns the color implementation of ExpiryBadge and BaseBadge components with current designs. A color contrast issue was resolved and the Counter badge was extended to support manual dark/light variants.

Why?

Consistency and improved accessability

Limitations and Notes

• This is a color-change only, except for two changes I made:
  • Icons now cannot shrink anymore (insufficient space for the badge text lead to the icons getting tiny since they are in a flex context)
  • Text within badges cannot break to a new line anymore (this cause the badge to scale out of proportion)
• The Notify ExpiryBadge currently fails a contrast check. I'm not sure if this was intended by design (cc @laurelterlesky), I added a Figma comment for that.

Applicable Issues

Closes #319

QA Log

• Manually checked every single Variant with the corresponding design and changed colors accordingly

Screenshots

ExpiryBadge

BaseBadge

[aaspinwall]

It looks great!

[davinotdavid]

LGTM, thanks! However, please check Laurel's comment in the Figma file and update the colour so that the contrast checks pass before merging.

[devmount]

@aaspinwall @davinotdavid Thanks so much for your reviews! I fixed the contrast issue now and added a manual dark/light variant for the counter badge (see Laurels comments). Can you take a quick look again?

[davinotdavid]

LGTM, thanks!