Rename renderNode → intercept; useFormTree({ defaults }) (#142) - #148
Merged
Conversation
…#142) Ship ADR 051 teaching names on React and vanilla. Kind-wide look binds via defaults; intercept stays the per-node SchemaFields prop. Core engine types are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #142 (child of #141).
Customize had two jobs under one name. This ships the ADR 051 split: defaults is the table
<Default />draws, intercept is this node.renderNode→interceptonSchemaFields/<Default />/ vanilladefaultAdapter→nativeDefaults,diagnosticAdapter→diagnosticDefaults, plusmergeDefaultson the renderer packagesuseFormTree(tree, { defaults })bindscreateRenderer(mergeDefaults(nativeDefaults, defaults))RendererAdapter/mergeAdapteruseTeamFormTreewrapper, not a library contextNo intercept-map sugar (#143) and no gallery rewrite (#146). Examples just got the rename so they compile.
Agent did the grind.
Test plan
useFormTree({ defaults })merges over native, not diagnostic (unspecified slots stay real HTML)interceptstill hijacks a node when defaults are boundmergeAdapter/RendererAdapter