feat(react): export field a11y and array-host defaults pieces (#154) - #157
Merged
Merged
Conversation
Custom field/array roots can compose useFieldA11y, FieldControlSlot, and ArrayHost instead of copying DefaultFieldRoot / array slot state. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #154 (child of #141). Stacks on #156 / #146.
Custom field/array roots can compose
useFieldA11y,FieldControlSlot, andArrayHostinstead of copyingDefaultFieldRoot/ array slot state. Error<ul>stays private; the seam isfieldErrorId.createRendererstill wrapsarray.rootinArrayHost.Agent did the grind.
Test plan
defaults.field.rootusing the pieces still getsaria-invalid/aria-describedbyparts.controloverride still receives error a11y on attrsdefaults.array.rootstill add/removes without remounting survivorsnpm run gateMade with Cursor