Unknown-shape field mode recipe (ADR 056, #74) - #169
Merged
Conversation
FormFrame does not evaluate rule_schema. Hosts fold into hidden / required / readOnly plus setValues; AJV compiles once and projects data and errors. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormFrame does not evaluate
rule_schema. Hosts fold into hidden / required / readOnly plussetValues. I think that's the right seam after the #164 spike; a Core runner would just be a third engine.Copyable recipe is
createFieldMode+createAjvValidator(schema, { fieldMode }). Same function drives the gallery field UI and AJV. Schema compiles once. Hidden paths get omitted on a clone, not pushed ontoschema.required.Claude helped with the matcher grind and caught a copy-per-hidden-path blowup (~100x AJV) that we fixed by deleting on the clone.
Layout (
SchemaFields layout/ ADRs 053–055) is still on the spike branch. Not this PR.Related to #74 (already closed). Precursor #164. First real consumer is #167.
Test plan
npm run gatelocallynpm test -w packages/react -- fieldMode(fold, AJV, gallery, 200-field stress, in-memory render counts)Made with Cursor