Run CI on main, and record that releases come from it - #9
Merged
Conversation
Both workflows triggered only on `master`, while every change since the fork diverged has landed on what was `tinbase-npm`. So `bun typecheck` / `bun test` and CodeQL have never run on any of it - the 3.3.0 through 3.5.0 work was verified only locally, and the default branch being stale is what hid that. With `tinbase-npm` renamed to `main` and made the default, both now trigger there. Verified the steps pass before pointing them at the default branch, so enabling this doesn't immediately paint it red: typecheck exit 0, test exit 0. Also drops `master` from the triggers rather than keeping both. It sits 14 commits behind with the unscoped package name, version 3.0.14 and the upstream repository URL, so building it would test something nobody ships. Upstream is tracked through the `upstream` remote instead, which is the usual arrangement for a fork that publishes under its own name rather than one that contributes back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to renaming
tinbase-npm→mainand making it the default branch.CI has never run on this fork's work
Both workflows triggered only on
master:Every change since the fork diverged landed on
tinbase-npm, sobun typecheck,bun testand CodeQL have never run on any of it. Everything from 3.3.0 through 3.5.0 was verified by local runs only. A stale default branch is exactly what hides this: nothing looks broken, because nothing looks at all.Both now trigger on
main.Verified before flipping it
Enabling CI on a branch it has never run against can just paint the default branch red, so I checked the steps first:
Why
masteris dropped from the triggers rather than kept alongsidemasteris 14 commits behind and carriesname: "pg-mem",version: 3.0.14and the upstream repository URL — the pre-fork identity. Building it would test something nobody ships, and it would produce failures unrelated to any change under review.Upstream is tracked through the
upstreamremote (oguimbal/pg-mem), which is the usual arrangement for a fork that publishes under its own name rather than one whose purpose is contributing back.masteris vestigial now; it can be deleted whenever you like, though it costs nothing to leave.The CHANGELOG header is updated to match, since it documented the old branch layout.
Note
#8 is still open and also targets
mainnow — the rename retargeted it automatically. It carries the positional ORDER BY fix, which is the one piece of 3.5.0 not yet on the default branch.