fix: walk parent-view chain before CreateDatabase save#17
Merged
Conversation
BinaryView.CreateDatabase passed its own handle straight to BNCreateDatabase, but a derived view (e.g. the ELF view layered on raw bytes) cannot own a database: BNCreateDatabase must run against the root (raw) parent view. Saving a freshly loaded binary therefore returned false and wrote a truncated 90112-byte database. Now CreateDatabase walks this.Parent to the root first, matching C++ BinaryView::CreateDatabase (binaryview.cpp:1673) and Python FileMetadata.create_database (which passes self.raw.handle). SaveAutoSnapshot is unchanged: C++ SaveAutoSnapshot does not walk the parent, passing 'this' directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryView.CreateDatabasepassed its own handle straight toBNCreateDatabase, but a derived view (e.g. the ELF view layered on raw bytes) cannot own a database:BNCreateDatabasemust run against the root (raw) parent view. Saving a freshly loaded binary therefore returnedfalseand wrote a truncated 90112-byte database.Now
CreateDatabasewalksthis.Parentto the root first, matching C++BinaryView::CreateDatabase(binaryview.cpp:1673) and PythonFileMetadata.create_database(which passesself.raw.handle).SaveAutoSnapshotis unchanged: C++SaveAutoSnapshotdoes not walk the parent, passingthisdirectly.Reproduced against the official Python binding:
bv.create_database(...)succeeds (valid 675840-byte.bndb); the C# call failed before this fix and succeeds after.Verification: added a regression test (
CreateDatabaseRoundTripTests) that openscat.bndb(ELF view with a Raw parent), saves a temp.bndb, reloads it, and asserts the functions survive. Confirmed it fails without this fix and passes with it.