Beta 1.8.4 - #419
Merged
Merged
Beta 1.8.4#419
Conversation
* implement fixes for 1.8.3 Signed-off-by: jquick <iammazungu@gmail.com> * lock skill packets unless its enabled Signed-off-by: jquick <iammazungu@gmail.com> * add missing assets Signed-off-by: jquick <iammazungu@gmail.com> --------- Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
- Improved spell and ability checks so known actions are not marked unavailable - Made every macro use a unique id so slots always point to the right macro - Saved pending palette and macro edits before job changes so bars stay intact - Fixed pet abilities and maneuvers staying lit up after the pet was dismissed - Fixed shared cooldowns so Puppetmaster maneuvers all show the same timer - Added cost display for MP, TP, charges, and finishing moves on hotbar slots - Added Scholar stratagem charges and Dancer finishing move counts including 5+ from Job Points - Zeroed costs correctly during Trance, Tabula Rasa, Manafont, and Manawell - Added an Other job category for non standard jobs like Monstrosity
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
* add phantomroll Signed-off-by: jquick <iammazungu@gmail.com> * fix time zero Signed-off-by: Jared Quick <jared.quick@salesforce.com> * fix double bust issue Signed-off-by: jquick <iammazungu@gmail.com> * cleanup Signed-off-by: jquick <iammazungu@gmail.com> * Add color placeholder Signed-off-by: jquick <iammazungu@gmail.com> * set default horizon mode Signed-off-by: jquick <iammazungu@gmail.com> * cleanup Signed-off-by: jquick <iammazungu@gmail.com> * fix time durations Signed-off-by: jquick <iammazungu@gmail.com> * clean up variable names and comments Signed-off-by: jquick <iammazungu@gmail.com> * fix demo mode for chaos Signed-off-by: jquick <iammazungu@gmail.com> --------- Signed-off-by: jquick <iammazungu@gmail.com> Signed-off-by: Jared Quick <jared.quick@salesforce.com>
* ci: validate changed Lua syntax (#1) Adds a fast MoonJIT syntax gate for Lua changed relative to the pull request base. This is the syntax foundation for remediation branches based on beta 1.8.4. * fix: load readycheck audio lazily (#2) Defers WinMM acquisition until scaled Ready Check audio actually needs native playback.
* Improved Job Lists And Hotbar Loading - Jobs the player has not unlocked are now hidden from the macro and palette menus - Fixed Made Blue Mage and other later jobs to show under their own names instead of `Other` - Made the hotbar load the correct job as soon as you log in instead of waiting and sometimes staying blank * Improved Skillchain Highlights On The Hotbar - Updated skillchain highlights to work on spells, blood pacts, and pet ready moves. - Added options to require Chain Affinity or Immanence to highlight spells and for highlighting all blood pacts. * Improved Target Bar Debuffs And Skillchain Data Lists - Added timers for more debuffs including blue magic and other sources - Added song duration sliders in the target bar settings - Extra duration from merits and job points from the player are now applied - Horizon debuff duration and skillchain lists now only have the values that differ from retail * Improved Bard Song Duration Settings - Moved song duration sliders into a Bard Song Settings section - Removed extra symbols from the song names - Added extra Lullaby time from Bard job points - Added extra song time from the 1200 job point gift * Fixed Merge Conflicts With Beta - Restored the job list so names and Other still load - Fixed the hotbar so it binds your job after login - Fixed profile changes so bars refresh on the new profile - Fixed the Other job highlight in the macro palette - Fixed magic burst orbs after a skillchain Co-authored-by: Cursor <cursoragent@cursor.com> * Fixed Hotbar Spacing, Pet Commands, And Action Labels - Increased the amount of hotbars from 6 to 10. - Fixed stacked and multi row hotbars so they respect row and slot spacing. - Added a Word Wrap option for action labels and cuts off long text so nearby slots don't overlap. - Fixed pet shared cooldown timers and pet commands to only show abilities you currently know. - Allowed Summoner and Beastmaster pet bars to work when set as sub job. - Fixed Always Visible so each pet type only shows when that type is turned on. * Added Bonus Charisma Setting For Charm Duration - Added a Bonus Charisma slider to the Charm Indicator setting. - Updated Charm duration formula to use Modified Charisma which is base Charisma plus Bonus Charisma. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
- Fixed skill names that showed an extra backslash before the apostrophe in words like Dancer's Fury
Fixed Horizon Skillchain Names
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
- Separated weapon skill debuffs from spell debuffs so they no longer mix up with each other - Added missing weapon skill debuffs and timed them using party or alliance TP when possible - Marked weapon skill debuffs as uncertain when we cannot confirm they landed - Added Feint so evasion down applies on the next melee hit instead of when the ability is used - Fixed Shadowbind so it tracks under the correct ability - Expanded extra effect timers for common weapon and ammo procs - Made Angon show as certain when it hits - Added Horizon only changes for Mug, Energy Drain, Gale Axe, Geirskogul, Blast Arrow, and Blast Shot - Confirmed uncertain debuffs when a matching spell has no effect because the enemy already has it - Cleared tracked debuffs when a spell shows the enemy is immune
- Fixed wrong job ability IDs so dancer steps, flourishes, Tomahawk, and similar abilities track under the correct ability - Added missing enemy debuffs from spells, pets, job abilities, and weapon skills - Marked effects as uncertain when they can miss or resist after a hit, and certain when they always land on a hit - Fixed weapon skill timers that used the wrong TP scaling - Stopped Angon and similar abilities from mixing up with weapon skills that share the same ID - Updated Horizon only changes for Mug, Energy Drain, Gale Axe, Geirskogul, Blast Arrow, Blast Shot, and Nightmare Scythe - Corrected several blue magic and other spell timers using wiki data if LSB data was missing
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Added Remaining Missing Debuffs - Fixed wrong job ability IDs so dancer steps, flourishes, Tomahawk, and similar abilities track under the correct ability - Added missing enemy debuffs from spells, pets, job abilities, and weapon skills - Marked effects as uncertain when they can miss or resist after a hit, and certain when they always land on a hit - Fixed weapon skill timers that used the wrong TP scaling - Stopped Angon and similar abilities from mixing up with weapon skills that share the same ID - Updated Horizon only changes for Mug, Energy Drain, Gale Axe, Geirskogul, Blast Arrow, Blast Shot, and Nightmare Scythe - Corrected several blue magic and other spell timers using wiki data if LSB data was missing - Fixed JA type comments Note: Important JA's can sometimes appear in packet type 6 but are mainly a type 3 which is why some abilities are duplicated.
- Added a banner and sound that play when you learn a Blue Magic spell - Added a Blue Magic tab under Notifications Settings for its options - Moved the existing notification options into a General tab - Made the banner follow the global UI lock so it cannot be moved when lock is on
Added Blue Magic Learned Notification - Added a banner and sound that play when you learn a Blue Magic spell - Added a Blue Magic tab under Notifications Settings for its options - Moved the existing notification options into a General tab - Made the banner follow the global UI lock so it cannot be moved when lock is on
Signed-off-by: jquick <iammazungu@gmail.com>
Changed BLU Spell Learned Image
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
- This change prevents thet pet bar window from nudging upward on login while using the bottom align option
- Made the palette manager open to shared by default - Made pet palette keys use the pet name only so they stay the same across job and sub job changes - Gave each jug pet its own palette while keeping one shared palette for Charmed pets - Showed the right jug pets for horizon versus retail and added spaced names in the dropdown list - Removed redundant palette settings from the global and bar config tabs - Fixed the palette manager button text getting cut off - Fixed copying macros into other so they show up correctly instead of only changing the count
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
New Features