fix: create ND2 frame views with reshape - #302
Closed
stanbot8 wants to merge 2 commits into
Closed
Conversation
stanbot8
force-pushed
the
fix/reshape-read-frame
branch
from
July 27, 2026 05:44
b298699 to
55c625a
Compare
tlambert03
reviewed
Jul 29, 2026
| DATA = Path(__file__).parent / "data" | ||
|
|
||
|
|
||
| @pytest.mark.filterwarnings( |
Owner
There was a problem hiding this comment.
thank you @stanbot8
I don't understand, however, why we're adding this filterwarnings here?
we already globally elevate warnings to errors, and your fix was sufficient, no?
Owner
|
thanks for the contrib. I had to do the same one-line fix in #298 in order to get it in, so this is redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ND2File.read_framechanges the returned array shape through attribute assignment. Create each ND2 frame view with reshape. This keeps frame creation on the supported NumPy array API and avoids the NumPy 2.5 deprecation. Closes #301. All tests pass.