Run the events, follow and policy suites in just test - #27
Open
0bserver07 wants to merge 3 commits into
Open
Conversation
The third command of the test recipe, justfile line 86, named eight walgit-server test binaries, and crates/walgit-server/tests/ holds three more. No other recipe named them: ci at line 118 is warnings clippy test e2e, and e2e at line 90 runs only --test e2e, so events.rs, follow.rs and policy.rs never ran on a laptop or in CI even though they compile under just clippy. This appends --test events --test follow --test policy to that command. The three suites pass today, seven tests in about five seconds, and .github/workflows/ci.yml line 58 runs just test, so the change reaches CI without editing the workflow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
.github/workflows/ci.yml pinned node-version: 22 at lines 46 and 78, while every other place that builds the SPA asks for Node 24: README.md line 118, flake.nix line 69 and Containerfile line 17. CI ran just web-build on a different major than a contributor's laptop or the OCI image, so a problem that shows up on only one of them could pass unnoticed. Both setup-node steps now say 24. GitHub Actions does not run locally here, so the check is that the workflow now agrees with those three files rather than a test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
README.md line 158 called just ci "all of the above" after a list of three commands, but the recipe at justfile line 118 is ci: warnings clippy test e2e and AGENTS.md section 5 names those same four gates. A reader following the README skipped the clippy gate on a laptop and met it for the first time in CI. The block now lists just clippy next to the other three and says what just ci actually runs. This is documentation, so the check is that the list matches justfile line 118. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
just testrecipe names eight of the walgit-server test binaries.events.rs,follow.rsandpolicy.rsincrates/walgit-server/tests/aren't in that list or in any other recipe, so they have never run locally or in CI (CI just callsjust test). This adds them. They pass as they are: seven tests in about five seconds.Two small things fixed while in there:
.github/workflows/ci.ymlpinned Node 22 whileREADME.md,flake.nixand theContainerfileall say 24; both setup-node steps now match.just ci"all of the above" but the list left outjust clippy, which the recipe runs.Checked by running the recipe's third command as it now reads: eleven suites, 45 tests, all green. No Rust changes. I couldn't run the GitHub workflow itself, so the Node bump is verified by reading, not by a run.