Repository navigation
Conversation
Pin the exact head of tombl/linux#58 and update its source NAR hash. This lets distro CI validate the clone failure cleanup with the full package and guest check suite before either PR is merged. Linux branch: fix/wasm-clone-failure-cleanup Linux commit: 6ee1a9c24b9a5f86c2288ab5bc0447935e826a05 Link: tombl/linux#58
The kernel mirror bases already end in /pub/. Drop the extra pub/ component from these source URLs so fetchzip no longer requests /pub/pub/ paths and fails with 404s. Verified both corrected URLs and their existing unpacked NAR hashes. This unblocks distro CI for the Linux clone cleanup integration pin.
Update the Linux pin to 5ad61429eac77535a904e70153ce1502bc82ff86, the commit merged into wasm from tombl/linux#58. The merged tree matches the previously tested PR head. Recomputed the unpacked source NAR hash from the merged commit archive; it is unchanged.
tombl
changed the title
The socket and pidfile appear before uuidd blocks signals and sets up signalfd. An early SIGALRM can reach the startup timer handler, which ignores externally generated signals, leaving the exit test waiting. Require a successful random UUID request and validate its response before reporting readiness. Use one bounded five-second request, with no retries, and preserve the existing signal exit, status and cleanup assertions.
The inactivity service can remove its pidfile before the parent reads it after the protocol readiness request. Wait for the known foreground child PID instead, preserving the bounded exit wait, status and cleanup checks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin Linux to
5ad61429eac77535a904e70153ce1502bc82ff86, the commit merged intowasmfrom tombl/linux#58, which frees the clone callback allocation when task creation fails.The pin also includes upstream's intervening Wasm modpost preparation fix. Correct the Git and util-linux source mirror paths: the kernel mirror base already ends in
/pub/, so the extrapub/caused 404s. Package versions and their source hashes are unchanged.The uuidd programs test waits for a successful, validated random UUID response before sending signals. Socket/pidfile existence precedes signalfd setup, allowing an early external SIGALRM to be consumed by the startup timer handler. The readiness request has a five-second timeout with no retry. The inactivity test tracks its known foreground child PID because the service may remove its pidfile before the parent reads it. Existing exit, status, and cleanup assertions remain intact.
Validation:
44a5dbc860e6809313e0660e5b415c69f79becea: the main build, all 111 heavy checks (including util-linux programs), and preview deployment. Release publication was skipped.dash -npassed. A focused host shell harness accepted a valid readiness response and rejected command failure, timeout status, and malformed output.CI provides distro integration validation, not a dedicated runtime measurement of the clone error-path memory leak.