PM-5961: only allow deleting submissions while their submission phase is open

[jmgasper]

What was broken

In Design challenges the submitter could still delete a submission after the phase that created it had ended. A checkpoint submission stayed deletable for the whole Submission phase, so it could be removed after it had already passed Checkpoint Screening and been scored in Checkpoint Review — exactly the scenario in the PM-5961 recording.

Expected behaviour: a submission can only be deleted while the phase that produced it is open (Checkpoint Submission for checkpoint submissions, Submission for contest submissions), and nothing is deletable once every submission phase is closed.

Root cause

SubmissionsTable computed the delete permission from a single submissionPhaseStartDate prop, which the container derived as the start date of any open Submission or Checkpoint Submission phase:

const allowDelete = submissionPhaseStartDate
  && moment(subObject.submissionDate).isAfter(submissionPhaseStartDate);

Two problems:

1. submissionDate is not a field on member submissions (they expose created), so moment(undefined) resolved to "now". The expression collapsed to "now is after the open phase start", i.e. always true whenever any submission phase was open.
2. Even with the right date field, the check never looked at the submission's own type, so a checkpoint submission was treated as belonging to the open Submission phase.

What was changed

• Added belongsToActiveSubmissionPhase() to utils/challenge-detail/submission-limit. It reuses the existing getActiveSubmissionType() phase precedence (already used for submission limits and for typing new uploads) to decide whether a submission was created by the currently open submission phase, and returns false when no submission phase is open at all. Both the V6 type and the legacy submissionType fields are supported.
• SubmissionsTable now derives allowDelete from that helper against challenge.phases, so:
  • checkpoint submissions are deletable only during Checkpoint Submission,
  • contest submissions are deletable only during Submission,
  • nothing is deletable during screening / review / appeals / after completion.
• Removed the now-unused submissionPhaseStartDate prop from the submission management container and components (it existed only to feed the old check).

The existing "You can delete this submission only after the review is complete" workflow-run gating and the COMPLETED / Design-track conditions on the delete button are unchanged.

Any added/updated tests

__tests__/shared/utils/challenge-detail/submission-limit.test.js — new belongsToActiveSubmissionPhase suite:

• allows deleting a checkpoint submission (current and legacy type fields) while the Checkpoint Submission phase is open
• blocks deleting a checkpoint submission once the Submission phase opens, while still allowing contest submissions
• blocks deleting anything once every submission phase is closed (Checkpoint Review / Review open)
• resolves to false for missing submissions or missing phases

Also updated the SubmissionsTable shallow snapshot, which now records the boolean allowDelete={false} prop (previously undefined, and therefore omitted, because the test fixture supplies no submissionPhaseStartDate).

Validation run: npm run lint (clean), npm run jest — 380 passed, 141 snapshots passed, 0 failures; npm run build succeeds.

The companion API enforcement is in topcoder-platform/review-api-v6 PM-5961.

🤖 Generated with Claude Code