Skip to content

PM-5368: show cancelled Marathon Match test status in the work app - #2184

Open
jmgasper wants to merge 1 commit into
devfrom
PM-5368
Open

PM-5368: show cancelled Marathon Match test status in the work app#2184
jmgasper wants to merge 1 commit into
devfrom
PM-5368

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken

In the work app submissions table, a Marathon Match submission whose scorer was stopped because the member submitted a newer solution showed an empty Test Status cell with no explanation — exactly the state in the PM-5368 screenshots. Copilots and managers could not tell a superseded run apart from one that had never started.

Root cause

normalizeTestStatus in the work app challenge utils only recognized FAILED, IN PROGRESS and SUCCESS, so the CANCELLED status now recorded by marathon-match-api-v6 was normalized away and renderTestStatusIcon had no branch for it.

Separately, the placeholder aggregate score (-1) written for a terminal run that produced no score was only suppressed for IN PROGRESS runs, so a cancelled run would have rendered -1.00 in the Initial / Final Score column.

What was changed

  • normalizeTestStatus and the display status union accept CANCELLED, and a cancelled run is treated as terminal when ordering summations to pick the current one.
  • SubmissionsTable renders a neutral grey BanIcon for CANCELLED, so the run reads as "stopped" rather than "failed" — the ticket is explicit that cancelled must not be shown as a failure.
  • Score suppression is generalized from "in progress" to "produced no score", so a cancelled run shows the empty score placeholder instead of the -1 sentinel.

Any added/updated tests

  • src/apps/work/src/lib/utils/challenge.utils.spec.ts — new case covering that getSubmissionTestProgress surfaces a cancelled provisional run with its process and progress.
  • src/apps/work/src/lib/components/SubmissionsTable/SubmissionsTable.spec.tsx — new case covering that a superseded run renders the cancelled status icon and no aggregate score; the ~/libs/ui mock gained BanIcon.

Commands run: tsc --noEmit (clean), eslint over src/apps/work/src/lib (clean), and craco test --watchAll=false --testPathPattern "apps/work/src/lib". SubmissionsTable.spec.tsx and challenge.utils.spec.ts pass; the 2 failing suites in that run (PaymentFormModal, AcceptApplicationModal) fail identically on dev without this change.

Related PRs

  • marathon-match-api-v6: cancel a member's in-flight MM scorer before scoring their newest submission
  • review-api-v6: allow CANCELLED through the member-safe review summation metadata allowlist
  • community-app: show cancelled Marathon Match scoring in My Submissions

🤖 Generated with Claude Code

What was broken
In the work app submissions table, a Marathon Match submission whose scorer was
stopped because the member submitted a newer solution showed an empty Test
Status cell with no explanation, matching the PM-5368 screenshots. Copilots and
managers could not tell a superseded run apart from one that had never started.

Root cause
normalizeTestStatus in the work app challenge utils only recognized FAILED,
IN PROGRESS and SUCCESS, so the CANCELLED status now recorded by
marathon-match-api-v6 was normalized away and the status icon renderer had no
branch for it. The placeholder aggregate score written for a terminal run
without a score was also only suppressed for IN PROGRESS runs.

What was changed
- normalizeTestStatus and the display status union accept CANCELLED, and a
  cancelled run is ordered as terminal when choosing the current summation.
- SubmissionsTable renders a neutral cancelled status icon so the run does not
  read as a failure.
- Score display suppression now covers any status that produced no score, so a
  cancelled run shows the empty score placeholder instead of the placeholder
  aggregate score.

Any added/updated tests
- src/apps/work/src/lib/utils/challenge.utils.spec.ts: new case covering that
  getSubmissionTestProgress surfaces a cancelled provisional run.
- src/apps/work/src/lib/components/SubmissionsTable/SubmissionsTable.spec.tsx:
  new case covering that a superseded run renders the cancelled status icon and
  no aggregate score.
@jmgasper
jmgasper requested a review from kkartunov as a code owner August 25, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant