Conversation
What was broken In the work app submissions table, a Marathon Match submission whose scorer was stopped because the member submitted a newer solution showed an empty Test Status cell with no explanation, matching the PM-5368 screenshots. Copilots and managers could not tell a superseded run apart from one that had never started. Root cause normalizeTestStatus in the work app challenge utils only recognized FAILED, IN PROGRESS and SUCCESS, so the CANCELLED status now recorded by marathon-match-api-v6 was normalized away and the status icon renderer had no branch for it. The placeholder aggregate score written for a terminal run without a score was also only suppressed for IN PROGRESS runs. What was changed - normalizeTestStatus and the display status union accept CANCELLED, and a cancelled run is ordered as terminal when choosing the current summation. - SubmissionsTable renders a neutral cancelled status icon so the run does not read as a failure. - Score display suppression now covers any status that produced no score, so a cancelled run shows the empty score placeholder instead of the placeholder aggregate score. Any added/updated tests - src/apps/work/src/lib/utils/challenge.utils.spec.ts: new case covering that getSubmissionTestProgress surfaces a cancelled provisional run. - src/apps/work/src/lib/components/SubmissionsTable/SubmissionsTable.spec.tsx: new case covering that a superseded run renders the cancelled status icon and no aggregate score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
In the work app submissions table, a Marathon Match submission whose scorer was stopped because the member submitted a newer solution showed an empty Test Status cell with no explanation — exactly the state in the PM-5368 screenshots. Copilots and managers could not tell a superseded run apart from one that had never started.
Root cause
normalizeTestStatusin the work app challenge utils only recognizedFAILED,IN PROGRESSandSUCCESS, so theCANCELLEDstatus now recorded by marathon-match-api-v6 was normalized away andrenderTestStatusIconhad no branch for it.Separately, the placeholder aggregate score (
-1) written for a terminal run that produced no score was only suppressed forIN PROGRESSruns, so a cancelled run would have rendered-1.00in the Initial / Final Score column.What was changed
normalizeTestStatusand the display status union acceptCANCELLED, and a cancelled run is treated as terminal when ordering summations to pick the current one.SubmissionsTablerenders a neutral greyBanIconforCANCELLED, so the run reads as "stopped" rather than "failed" — the ticket is explicit that cancelled must not be shown as a failure.-1sentinel.Any added/updated tests
src/apps/work/src/lib/utils/challenge.utils.spec.ts— new case covering thatgetSubmissionTestProgresssurfaces a cancelled provisional run with its process and progress.src/apps/work/src/lib/components/SubmissionsTable/SubmissionsTable.spec.tsx— new case covering that a superseded run renders the cancelled status icon and no aggregate score; the~/libs/uimock gainedBanIcon.Commands run:
tsc --noEmit(clean),eslintoversrc/apps/work/src/lib(clean), andcraco test --watchAll=false --testPathPattern "apps/work/src/lib".SubmissionsTable.spec.tsxandchallenge.utils.spec.tspass; the 2 failing suites in that run (PaymentFormModal,AcceptApplicationModal) fail identically ondevwithout this change.Related PRs
CANCELLEDthrough the member-safe review summation metadata allowlist🤖 Generated with Claude Code