Conversation
What was broken The My Active Challenges review endpoint did not return the number of challenge submissions or whether Iterative Review was currently open, so the review app could not flag Topgear Task challenges where submitted work was waiting but Iterative Review had not opened. Root cause (if identifiable) The my-reviews summary query only selected review progress and current phase details; it did not include the challenge submission count or an explicit Iterative Review phase-open signal. What was changed Added numOfSubmissions and isIterativeReviewPhaseOpen to the my-reviews DTO and summary query, including active and past query paths. Any added/updated tests Added service coverage that verifies the new fields are selected and returned for active review challenges.
PM-5059: Expose active review submission state
What was broken Registered Marathon Match submitters could only retrieve their own review summation rows, so the Community app could not show other competitors' summation scores before challenge completion. Root cause The review summation search path validated submitter access for Marathon Match challenges, then still added the requester member id to the submission filter. What was changed Removed the submitter member-id filter after Marathon Match registration/type validation, allowing registered competitors to fetch challenge-level review summations while preserving the existing metadata sanitization. Any added/updated tests Updated the review summation service unit test to cover multiple submitters' summations and verify per-seed metadata remains hidden.
PM-5111: Allow marathon submitters to view scores
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.