Conversation
…tch-to-gitea PM-5118 directly dispatch to gitea
What was broken F2F public reviewer applications could still be approved into the generic Reviewer resource role when the stored review opportunity/application looked like a regular review. That left the approved member off the Iterative Review tab. Root cause The previous fix only corrected missing review opportunity types during opportunity creation. Work Manager-created F2F challenges can persist a reviewer config on the Iterative Review phase with an explicit REGULAR_REVIEW type, and review-api approval trusted that regular opportunity type when choosing the resource role. What was changed Review application approval now detects regular reviewer applications for First2Finish challenges whose member reviewer config is attached to the Iterative Review phase and assigns the Iterative Reviewer resource role. Existing non-F2F regular review approvals continue to assign the Reviewer role. Any added/updated tests Added ReviewApplicationService coverage for assigning Iterative Reviewer on F2F iterative review approvals and preserving the regular Reviewer role when the F2F iterative config is not present.
PM-4691: assign iterative reviewer role for F2F approvals
…ancelled-jobs Pm 5118 do not retry cancelled jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.