Conversation
…ewer-context PM-5365 - Allow creating review context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the challenge review context feature to allow creating a review context for any existing challenge, not just those in DRAFT or REGISTRATION phases. However, updating a review context is still restricted to challenges in DRAFT status or with an open registration phase. The changes also add comprehensive unit tests for these behaviors and clarify related error messages.
Access control and validation changes:
Testing improvements:
challenge-review-context.service.spec.tsto verify the new and existing behaviors for creating and updating review contexts under different challenge statuses and phases.