draft: Refactor OAuth Social Providers - #273
Draft
UserNobody14 wants to merge 7 commits into
Draft
Conversation
ignatz
force-pushed
the
dev
branch
5 times, most recently
from
August 3, 2026 16:55
771ec79 to
0c6e85b
Compare
ignatz
force-pushed
the
dev
branch
3 times, most recently
from
August 4, 2026 15:57
4e647cb to
b5413f6
Compare
Contributor
|
Had a first skim. Looks promising. Never loved the verbosity, so pulling in a second layer for providers that can remain mostly declarative makes a lot of sense 👍 My only concern with the OAuth code in general is that it's hard to impossible to test :/. Did you have the chance to test a one or more providers? 🙏 EDIT: Are you still iterating or is this good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the repetitive oauth provider code into a series of handy flexible traits, and added tests for the many different quirks of the providers.
I also believe this is a solution to #215, allowing more configurable scopes to be entered, and eliminating email requirements for providers that may not furnish them for one reason or another.
Looking at ways to reduce the line count on this one, i still feel its a bit repetitive.