Add missing rows.Err() check in AWS consumeEntries - #1176
Merged
Merged
Conversation
roger2hk
force-pushed
the
aws-rows-err
branch
from
September 14, 2026 17:14
b77ebea to
7f10903
Compare
AlCutter
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the fix for the issue found by Go Analysis.
for rows.Next()stops for two different reasons, and they're indistinguishable without an extra check:Why that's dangerous here specifically: this is the sequencing consume path. If the query is truncated early by an error, the code would happily treat a partial result set as "that's all there was", then go on to consume/integrate only some of the entries — or, if zero rows were read, return
false, nil("nothing to sequence") when actually the DB call failed. Silent data-correctness bug rather than a loud error.