Bump formats & witness, along with fixups - #1183
Merged
Merged
Conversation
AlCutter
force-pushed
the
bump_formats_witness
branch
from
September 17, 2026 17:07
5326fc7 to
ffa691d
Compare
phbnf
approved these changes
Sep 18, 2026
| CosignerID: cosignerID, | ||
| Signature: s, | ||
| CosignerID: cID, | ||
| Signature: sigRaw[8:], |
Contributor
There was a problem hiding this comment.
Maybe add a comment to explicitly say we're stripping the timestamp for now.
Collaborator
Author
There was a problem hiding this comment.
There's no change from the old behaviour in that respect, so I think the function comment on L52 probably does the job?
I have made the discarding of the timestamp more obvious, though.
AlCutter
force-pushed
the
bump_formats_witness
branch
from
September 18, 2026 09:55
ffa691d to
dc8f88d
Compare
…666c09683aa9350785e572be27f0c026d
AlCutter
force-pushed
the
bump_formats_witness
branch
from
September 18, 2026 10:01
dc8f88d to
1331c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
formatsandwitnessdeps to bring in recent changes toSignSubtree.SignSubtree.