Skip to content

[BUGFIX] Process US regions without border countries - #297

Draft
Mirochill wants to merge 1 commit into
treee111:developfrom
Mirochill:fix-288-us-region-nbc
Draft

[BUGFIX] Process US regions without border countries#297
Mirochill wants to merge 1 commit into
treee111:developfrom
Mirochill:fix-288-us-region-nbc

Conversation

@Mirochill

Copy link
Copy Markdown

This PR...

  • Keeps -nbc country runs for Geofabrik IDs like us/texas aligned with the tile names generated by CountryGeofabrik.
  • Adds a regression expectation for us/texas so no-border processing uses us_texas, matching the split tile filenames.

Considerations and implementations

When border-country processing is disabled, CountryOsmData previously kept the raw wanted map id in border_countries. For US regions this meant us/texas, while CountryGeofabrik.find_needed_countries() normalizes tile country names to us_texas. The later split and merge stages compare those names, so no country split files were added to the Osmosis merge command.

This normalizes the no-border country key in the same way as the tile list and downloaded map filenames.

Fixes #288

How to test

  1. Not run locally.
  2. git diff --check

Pull Request Checklist

@cviebrock

Copy link
Copy Markdown

Maybe you can help @Mirochill ... even with your fix, why does this work:

python -m wahoomc cli -nbc -v -co "us/texas"

but this doesn't:

python -m wahoomc cli -nbc -v -co "canada/ontario"

I get the error:

Entered country 'canada/ontario' is not a geofabrik country.
Please check this URL for possible countries: https://download.geofabrik.de/index.html

Is the US the only region that can be filtered by subregion?

@cviebrock

Copy link
Copy Markdown

Nevermind ... -co ontario works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Osmosis error when generating individual US states or EU cities without bordering areas

2 participants