feat: Remote SSH PRD Phase 4 — Native desktop SSH transport - #370
Open
Ziinc wants to merge 2 commits into
Open
Conversation
Ziinc
force-pushed
the
claude/remote-ssh-prd-phase-3
branch
from
August 28, 2026 15:19
dddd041 to
b841412
Compare
Ziinc
force-pushed
the
claude/remote-ssh-prd-phase-4
branch
from
August 28, 2026 15:21
f01b6bc to
eaf7b9e
Compare
Ziinc
changed the title
Implements the Phase 4 "Native desktop SSH" delivery phase from prds/remote-ssh.md: a pure-Rust russh-based client transport that replaces system ssh subprocesses for the managed SSH path. - Strict host-key verification against Phase 3's TrustedHostKey fingerprints, with no bypass and no fallback to the OS known_hosts. - Client authentication via existing private key or certificate+key, consuming the Phase 1 SshAuthentication/SshEndpoint model. - A connection pool keyed on endpoint id, generation, hostname, port, username, and host-key fingerprints, reusing one authenticated connection across exec and PTY channels with keepalives and transparent reconnect of dead connections. - Non-interactive exec channels for `treq <command> --format=json` with total deadlines, output size limits, cooperative cancellation, and a structured error type distinguishing host-key, auth, deadline, output-limit, cancellation, and command-failure outcomes. - Interactive PTY channel primitive (open/write/read/resize/close) for later terminal/agent wiring. Unit tests cover host-key accept/reject, pool key derivation, and exec-channel deadline/output-limit/cancellation/reuse behavior against an in-process russh::server mock, with no network or real credentials.
Ziinc
force-pushed
the
claude/remote-ssh-prd-phase-4
branch
from
August 28, 2026 16:15
eaf7b9e to
dcc2d1b
Compare
Contributor
|
🚀 Web preview: https://preview-370.treq-9zy.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #369 (Phase 3). Implements Phase 4 of
prds/remote-ssh.md("Native desktop SSH") in a new module,src-tauri/src/core/remote_ssh_transport.rs, built onrussh.TrustedHostKeyfingerprints — no bypass, no trust-on-first-use, independent of~/.ssh/known_hosts.SshAuthenticationmodel.treq <args> --format=jsonwith deadline, output-size cap, cancellation, and a structuredSshTransportErrorfor Phase 5 callers.Scope notes
sshsubprocess call sites (core::remote.rs:SshCliTransport,check_readiness,probe_repo,clone_repo,build_ssh_shell_command) are left untouched. They operate on the legacy alias-basedSshHostmodel, not the Phase 1SshEndpoint/SshAuthenticationmodel this transport consumes — rewiring those call sites onto the new transport is Phase 5/6's job (typed CLI commands + UI integration). No new code path in this PR shells out tossh.Test plan
cargo build,cargo fmt --check,cargo clippy --lib(0 new warnings)cargo test --lib remote_ssh_transport— 13/13, using an in-processrussh::servermock (no network/real credentials)cargo test --libfull suite — 382 passed; 11 pre-existing failures unrelated to this change (nojjbinary in sandbox, confirmed present on pre-change baseline too)Stacked PRs: feat: Remote SSH PRD: Phase 2 — Sprites provisioning #368 (Phase 2) ← feat: Remote SSH PRD: Phase 3 — SSH trust and authentication #369 (Phase 3) ← this (Phase 4).
Generated by Claude Code