fix: OTLP nanosecond timestamp overflow in webapp event repository - #4747
Conversation
|
|
Hi @Roshan931, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThe change centralizes date-to-nanoseconds conversion in event timestamp, duration, and retry-scheduling paths. It replaces inline millisecond-to-nanosecond calculations with ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| export const EVENT_STORE_TYPES = { | ||
| POSTGRES: "postgres", | ||
| CLICKHOUSE: "clickhouse", | ||
| POSTGRES: "postgres", CLICKHOUSE: "clickhouse", |
There was a problem hiding this comment.
🟡 Object literal breaks formatter check
The EVENT_STORE_TYPES literal puts POSTGRES and CLICKHOUSE on one line with a double space. oxfmt reformats this, so the code-quality CI check fails on the diff.
| POSTGRES: "postgres", CLICKHOUSE: "clickhouse", | |
| POSTGRES: "postgres", | |
| CLICKHOUSE: "clickhouse", |
Was this helpful? React with 👍 or 👎 to provide feedback.
Fixes #3292
Root cause
Epoch milliseconds multiplied by 1e6 as a JS Number before BigInt conversion
Changes