chore: bump low-risk frontend/backend dependency versions - #178
Open
tsg21 wants to merge 2 commits into
Open
Conversation
- eslint-plugin-react-hooks 7.0.1 -> 7.1.1, typescript-eslint 8.58.1 -> 8.66.0 - Refresh backend uv.lock (h2 4.4.0 -> 4.4.1 transitive patch) No known CVEs found in current dependency set (npm audit, pip-audit). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fNkidbmfhBgUECrz9A6bV
typescript-eslint/eslint-plugin-react-hooks 7.1 adds two new rules that flagged existing code: - react-hooks/set-state-in-effect: DesignsWorkspace, ResearchWorkspace, and useGameState reset local state synchronously when a derived value changed. Switched these to the React-recommended "adjust state during render" pattern (track the previous value in state, compare, and setState conditionally during render) instead of an effect. - GameLobby and useGameState also call an async data-fetching callback directly from a triggering effect; the linter traces into useCallback-defined async functions and flags their synchronous pre-await setState calls. Deferring the call with queueMicrotask lets the effect's own commit finish before the fetch's state updates land, which is the actual behaviour the rule is protecting against, without changing the callbacks themselves. - react-hooks/refs: useGameState wrote to a ref during render to keep it in sync with the latest gameId/player; moved the write into an effect (all reads of the ref only happen from async callbacks after commit, so this is behaviourally equivalent). Verified: npx eslint src/, npm run typecheck, npx vitest run (355 passed), npm run build all pass locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fNkidbmfhBgUECrz9A6bV
Owner
Author
|
Pushed a fix for the frontend lint failure — the
Verified locally: Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine dependency audit. Bumps the low-risk, non-breaking updates only:
eslint-plugin-react-hooks7.0.1 → 7.1.1 (minor)typescript-eslint8.58.1 → 8.66.0 (minor)backend/uv.lockrefreshed:h24.4.0 → 4.4.1 (transitive patch, no CVE — just a routine release)Security
npm audit: 0 vulnerabilitiespip-audit(backend): no known vulnerabilitiesNot included here — flagged for manual review
These have breaking-change surface and weren't auto-applied:
eslint9→10,typescript5.9→7.0,jsdom29→30,@testing-library/jest-dom6→7,lucide-react0.577→1.28,@eslint/js9→10actions/setup-nodev4→v7,google-github-actions/authv2→v3,google-github-actions/setup-gcloudv2→v3 — all majors requiring Node 24+ on the runner (satisfied byubuntu-latest), so should be safe, but this session's credentials don't have theworkflowOAuth scope needed to push changes to.github/workflows/*. Recommend applying these bumps manually.hashicorp/googleprovider~> 6.0→ latest7.42.0(major, breaking). Left untouched per repo guidance that infra changes affecting live Cloud Run/IAM need careful blast-radius review before touching.Test plan
npm installsucceeds,npm auditcleanuv sync --lockedsucceeds after lock refreshGenerated by Claude Code