Admin console sidebar refactor: module panel through task 16 verification - #2857
Open
twoimo wants to merge 25 commits into
Open
Admin console sidebar refactor: module panel through task 16 verification#2857twoimo wants to merge 25 commits into
twoimo wants to merge 25 commits into
Conversation
Move menu-specific skeleton screens into AdminConsoleModuleSkeleton with an exhaustive menu-id shape map, and load all 15 console panels through a dynamic() registry that shows those skeletons instead of null. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Adjust preload and thumbnail-skeleton assertions after the module loading path moved out of AdminConsoleOverview. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
twoimo
marked this pull request as ready for review
September 3, 2026 10:53
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Apply loading, empty, error, and unauthorized markers plus output-kind attributes through a shared completeness host. Keep retry on the same canvas request and send re-login back to the active menu canonical href. Add Property 3 derived-set equality coverage. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Add AdminConsoleModuleGrid on the overview dashboard after the KPI panel. Cards use registry title, purpose, section, and primary action. Search and section filters share filterAdminConsoleMenus, keep IME composition out of the committed query, and announce result counts. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Add the shared viz card, tone-scale hook, state resolver, and 11 chart forms. Replace overview hex series colors with the console tone scale and lock Property 15 plus source contracts. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Keep the UI/UX source tests aligned with the 24px visualization card radius. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Replace the read-only llm workspace and audit placeholder with dedicated ops-assist and audit-events panels, add the shared risky-work procedure and adminJson helper, and tighten the user-display privacy boundary. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Avoid substring false positives on emailMaskToken/emailConfirmedAt, accept delegated storyboard RAG admin auth, and check forbidden risky-work step names on the UI steps rather than the constant list source. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Add a blocking inline prelude on the admin layout that reads tzudong-admin-theme, sets the dark class before paint, and records system when the stored value is missing or invalid. Expose series count/point attributes for light/dark parity checks. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Replace the placeholder stub so the admin console can render and the brightness-mode browser tests can reach visualization surfaces. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Wait for known viz cards before comparing light and dark series, and assert the prelude from the first HTML response instead of a hydrated script node. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Keep the routes map in AdminOverviewDashboard. Insights now owns the video-level treemap and range-band cards, and does not read pending counts. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Invert leftover hue-shell assertions, require 15 shells and 45 state markers, register spec unit files in the nightly unit lane, and mark task 13 done. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Record task 14 evidence: 131 console integration unit tests passed. Leave task 15 and pre-existing CI failures untouched. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Windows npm lint failed on WaterfallDeltaStep cursor reassignment. Move waterfall and gauge arc accumulation into pure helpers. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Scan saved Playwright evidence for the six forbidden kinds before write, skip the file when any kind is present, and register the unit coverage in the nightly unit lane. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Cover 15-menu hydration, sidebar IA, keyboard order, module-grid IME filters, and 360/768/1280 responsive chrome. Leave task 16 unchecked. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Ignore mid-composition input when committing module-grid search, and re-apply order-editor focus after the persisted order re-renders. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Wait for settled chrome, accept module-state as a ready surface, and avoid detached-node scrolls so the new browser suite stays deterministic. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Run the spec 16.1 trio and leave 16 unchecked. Requirement 21-10 (0 fail / 0 skip) is not reached: unit 19 fail + 1 placeholder error, typecheck only guardian.ts, Playwright aborts before collection. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
cursor
Bot
changed the title
Nested 7.x-10.x work and files are already on this branch. Check only the four parent boxes. Leave 16 and 16.1 unchecked. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Sidebar, registry, module-panel, users, audit, and adminJson now own the strings these tests still read from AdminConsoleOverview. Leave baseline home-map and guardian failures alone. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
Re-run is 1944 pass / 12 fail / 1 error. Leave 16 and 16.1 unchecked. Remaining blockers are baseline (guardian, lockfile, gen-types, home map, Playwright load abort), not the extracted console contracts. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
GitHub run 33760102273 red jobs match guardian.ts, frozen-lockfile, and supabase-gen-types.mjs on the base branch. Leave 16 unchecked. Co-authored-by: YEONWOO CHOI <twoimo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the admin-console sidebar refactor on
refactor/admin-console-sidebar(notdevelop).Task 16
16and16.1stay unchecked. Requirement 21-10 (0 fail / 0 skip) is not reached.Latest GitHub CI
33760102273on801658a1is red on Install, Ubuntu npm/Bun, Windows npm/Bun, and Admin. Those jobs fail only on files that are byte-identical torefactor/admin-console-sidebar(guardian.ts{"type":"exit"}, bun frozen-lockfile,supabase-gen-types.mjs). Admin eslint of this PR’s sidebar tests passed; tsc stopped onguardian.tsonly. No PR-introduced CI failure was found, so none of those files were edited.Local 16.1 re-run on this turn:
bun run test:unit— 1944 pass / 12 fail / 1 error / 0 skipnpm run typecheck:parity— exit 1; native tsc onlylib/privacy/guardian.tsnpx playwright test— exit 1 before tests (:3000already used)This PR does not claim GitHub CI is green.
Out of scope
Baseline defects left alone:
guardian.ts, bun frozen-lockfile,supabase-gen-types.mjs,admin-sidebar-order-hook.test.tsplaceholder.