Conversation
…20260905 Fix G037 read-only transaction admission order
Promote G037 transaction correction to data
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the reviewed G037 read-only transaction correction from protected data to main after PRs #2865 and #2866. Data is
6691c782a0f21d43c636ac72611ecfe4d47e6716, with the tested treef5a5312e59a81b7911f126fafc28476f35b2278f.The controller begins its shared read-only snapshot before role admission, fixing the PostgreSQL 25001 failure. Real PostgreSQL tests cover the old failure, privilege-only runtime probe, catalog rejection, write denial, and cleanup. Prior approval artifacts remain unchanged; their historical Git source and the current correction are verified separately.
Data promotion passed 35 effective checks with no unresolved reviews and a normal protected merge. One Windows sampler attempt failed before collecting samples; its artifact remains preserved, and one same-source retry passed official independent report validation with unchanged measurement budgets. No G003 application improvement is claimed.
This source promotion keeps the active write freeze, protected default main, and existing production deployment. No hosted mutation or production deployment is included. After main is installed and read back, a separately recorded fresh exact-main authorization allows one corrected read-only runtime probe; the previous failed G037 attempt remains immutable and is not retried.