Tpi 285 upgrade react by JaimeS98 · Pull Request #60 · tyro/tyro-pay-api-react-native

JaimeS98 · 2026-07-08T23:15:40Z

PR

Upgrade SDK to be compatible with RN v0.86.0 <-> RNv0.78.0
Upgrade Example app to be using RN v0.86.0 as our main target

Testing

Android

Screenshot_20260722_101043_Google Play services

iOS

… code and swift code

…use node 24 and setup correct version of ruby

…ger.swift

sanj-tyro · 2026-07-14T01:14:45Z

@@ -0,0 +1,5 @@
+// Global JSX namespace shim for @types/react@19 compatibility.
+// React 19 moved JSX to React.JSX; this restores the global JSX.Element alias.
+declare namespace JSX {


If we're setting up JSX as a global alias, is the import in some other specific files in this PR necessary?

Will look if they other imports are unnecessary now, cheers

fix: populate Gemfile.lock checksums after cocoapods upgrade update readme and e2e script to better select device update tests, and dependencies plus ci fix for ios update gemfile lock to point away from vulnerable activesupport versions and update ios-unit ci update to macoc-15 for unit create simulator for ios ci tests update podfile min target and build.gradle to not fail on emtpy tests remove duplicate ios simulators fix native unit tests update e2e tests make sure to install ios simulator update e2e github action to try and optimise the flow add concurrency cancel in progress to unit and dependency fix prepack order in android e2e added property check and restored challenge test to android fix gradle

sanj-tyro · 2026-07-23T22:50:37Z

@@ -0,0 +1,4 @@
+export enum Colors {


can we import the other one created? or not possible?

yeah can probably just have one actually.

sanj-tyro · 2026-07-23T22:52:53Z

    {paths: [process.argv[1]]},
  )', __dir__]).strip

-MIN_IOS_VERSION='16.0'


would've preferred to refer to this variable (wherever it is) and set that in one spot vs hard-coding here.

If we need to bump it up in the future, might be hard to know to do it here too

centralised it on package.json

…and fixing some types in tests podfile.lock update fix import for min ios version for example podfile

cmanchanda · 2026-07-28T04:24:21Z

+jobs:
+  android-e2e:
    runs-on: ubuntu-latest
+    timeout-minutes: 120          # <-- was unbounded (default 360 = your "hours")


nitpick, do we need the comments here?

cmanchanda · 2026-07-28T04:25:37Z

+          ./gradlew assembleRelease --no-daemon
+        env:
+          GITHUB_PACKAGES_USER: ${{ github.actor }}
+          GITHUB_PACKAGES_TOKEN: ${{ secrets.PACKAGE_READ_PAT }}


quick question, where does this token come from? does it ever expire? do we need to document something in the readme for the future

App platform set this for us I believe. I got them to update as it was expired when I started working on it. Might just put a note in the TYRO_README

cmanchanda · 2026-07-28T04:55:26Z

-        />
-      </SafeAreaView>
+      <SafeAreaProvider>
+        <SafeAreaView style={{ flex: 1, backgroundColor: 'transparent' }}>


nitpick, i know we introduced the enums for other colours, is this one not used widely enough?

Will add this one to the Colors enum, and then move the enum out of tests and update imports

cmanchanda · 2026-07-28T04:55:53Z

-    visible: "SUCCESS"
-    timeout: 150000
+    timeout: 300000
+# With the SDK upgrade we have lost the ability to detect the password field, 


any reason why all of these are a comment?

left as a reasoning for future improvement to restore this UI test to its full flow, but can probably just remove it fully

cmanchanda

lgtm with nitpicks

szhang-tyro · 2026-07-28T05:04:57Z

 rootProject.name = 'TyroPayApiReactNative'
-apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings)
 include ':lib'
 includeBuild('../node_modules/@react-native/gradle-plugin')


is this a duplication of the pluginManagement block?

We do need both here. without the root level includeBuild gradle would try and fetch it from maven repositories and the build will fail.

I just tried to remove it which caused the build to fail locally

szhang-tyro · 2026-07-28T05:09:06Z

 apply plugin: "com.android.application"
+apply plugin: "org.jetbrains.kotlin.android"
 apply plugin: "com.facebook.react"
 apply plugin: "kotlin-android"


Should we remove apply plugin: "kotlin-android" since we have the org.jetbrains.kotlin.android?

Yep it seems we can remove this

…d another color enum and accepted a security flag for a dev only dependency as no easy work around available update tyro read me, remove unused e2e test code and restore example gradle plugin

cmanchanda

lgtm

asdfghjklqwerty123 and others added 7 commits March 17, 2026 12:05

[TPI-285] Working android upgrade

71884b8

upgrade from 0.84 to 0.86, update tests and replace deprecated Kotlin…

4db40c7

… code and swift code

update pod file, tsconfig fix and ci release and unit tests

1fec3ae

vuln fix, changed pinned ruby version in gemfile, update ci tests to …

4c972a6

…use node 24 and setup correct version of ruby

add override for joi and brace-expansion dependencies

d4b2f64

add gemfile.lock so ci has right gems to install and cache

8ffcdec

updates to react native svg and apple pay button.swift and buttonmana…

b2e0a2d

…ger.swift

sanj-tyro reviewed Jul 13, 2026

View reviewed changes

Comment thread android/gradle/wrapper/gradle-wrapper.properties

sanj-tyro reviewed Jul 13, 2026

View reviewed changes

Comment thread android/lib/build.gradle

sanj-tyro reviewed Jul 14, 2026

View reviewed changes

Comment thread src/tests/test-components/App.tsx Outdated

sanj-tyro reviewed Jul 14, 2026

View reviewed changes

Comment thread ios/ApplePayButtonManager.swift

sanj-tyro reviewed Jul 14, 2026

View reviewed changes

Comment thread example/src/App.tsx Outdated

sanj-tyro reviewed Jul 14, 2026

View reviewed changes

Comment thread example/ios/Podfile

cmanchanda reviewed Jul 14, 2026

View reviewed changes

Comment thread android/lib/src/main/java/com/tyropayapireactnative/googlepay/GooglePayButtonManager.kt Outdated

cmanchanda reviewed Jul 14, 2026

View reviewed changes

Comment thread ios/TyroPaySdkModule.m

cmanchanda reviewed Jul 14, 2026

View reviewed changes

Comment thread Gemfile Outdated

cmanchanda reviewed Jul 14, 2026

View reviewed changes

Comment thread package.json Outdated

sanj-tyro reviewed Jul 14, 2026

View reviewed changes

Comment thread src/tests/WalletPaymentsContainer.spec.tsx Outdated

JaimeS98 force-pushed the tpi-285-upgrade-react branch from f1916b0 to c513585 Compare July 21, 2026 01:22

sanj-tyro reviewed Jul 23, 2026

View reviewed changes

moved min ios version to package.json keeping one Colors enum in sdk …

05e5aed

…and fixing some types in tests podfile.lock update fix import for min ios version for example podfile

JaimeS98 force-pushed the tpi-285-upgrade-react branch from e158dff to 05e5aed Compare July 24, 2026 00:29

cmanchanda reviewed Jul 28, 2026

View reviewed changes

update runner size for iose2e and reduce the timeout for android e2e

9c368ac

cmanchanda reviewed Jul 28, 2026

View reviewed changes

cmanchanda approved these changes Jul 28, 2026

View reviewed changes

szhang-tyro reviewed Jul 28, 2026

View reviewed changes

updates for recent PR comments, removed unneeded gradle imports, adde…

a5f705e

…d another color enum and accepted a security flag for a dev only dependency as no easy work around available update tyro read me, remove unused e2e test code and restore example gradle plugin

JaimeS98 force-pushed the tpi-285-upgrade-react branch from 873ba23 to a5f705e Compare July 28, 2026 10:51

cmanchanda approved these changes Jul 29, 2026

View reviewed changes

sanj-tyro approved these changes Jul 29, 2026

View reviewed changes

JaimeS98 merged commit 9ed2ec2 into master Jul 29, 2026
6 checks passed

JaimeS98 deleted the tpi-285-upgrade-react branch July 29, 2026 01:36

Uh oh!

Conversation

JaimeS98 commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

Testing

Android

iOS

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaimeS98 Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmanchanda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmanchanda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JaimeS98 commented Jul 8, 2026 •

edited

Loading

JaimeS98 Jul 23, 2026 •

edited

Loading