Swap Cheng for Blaskey when referencing the historical baseline - #728
Closed
Joshdpaul wants to merge 2 commits into
Closed
Swap Cheng for Blaskey when referencing the historical baseline#728Joshdpaul wants to merge 2 commits into
Joshdpaul wants to merge 2 commits into
Conversation
… and change source param to new "gcm_diff_applied_to_blaskey"
Contributor
|
I missed this PR and folded this work into the #730 PR. Closing this PR without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #726
This branch simply swaps "Cheng" with "Blaskey" everywhere, which fixes the citation issue. Test this alongside ua-snap/arctic_rivers#16 , which recreates the coverages with the correct name in the source dimension.