Fix two dead sh:targetClass IRIs in analysis.ttl - #695
Open
forest-savage1234 wants to merge 1 commit into
Open
Conversation
Point analysis:Analysis at analysis:Analysis (was action:Analysis). Point analysis:AnalyticResult at analysis:AnalyticResult (was AnalysicResult). Two tokens. No new terms. Closes ucoProject#694. Signed-off-by: Forest Savage <forestsavage03@gmail.com>
forest-savage1234
force-pushed
the
forest/uco-694-analysis-targetclass
branch
from
August 23, 2026 21:07
cb8fc8f to
ed7a521
Compare
Author
|
Thank you for the time on this review. This only fixes two dead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is a bug-fix change proposal, believed to be of low risk to the ontology and its downstream resources.
ontology/uco/analysis/analysis.ttlaims two node shapes at IRIs that are not the class (confirmed on #694):analysis:Analysiscurrently hassh:targetClass action:Analysis(wrong namespace).analysis:AnalyticResultcurrently hassh:targetClass analysis:AnalysicResult(typo).Both targets become the class IRI already defined in this file. Diff is two tokens (L31 and L55).
Closes #694.
Out of scope
configuration:ConfigurationEntryhas a property shape incorrectly permitting blank nodes #663 /uco-core:Compilationshould upstream an in-commonsh:PropertyShapeforuco-core:object#662catalog-v001.xml1.4.0 version stampsI am a volunteer. If either line is intentional, please say so and I will stand down.
Validation
make check(UCO CI)make --directory ontology/uco/analysis --file ../../../src/review.mk checkBoxes match commands actually run after the two tokens.
Box run 2026-08-22 11:00–11:18 PM AKDT on
/workspace/checkouts/UCOdevelop@586ac69(Merge pull request #688 from ucoProject/release-1.5.0) plus this two-token patch only. Not bundled with #663 / #662. Python 3.13.5.file-level (after
rm -f .check-analysis.ttl)make checkElapsed 1078559 ms, ended 2026-08-23T07:18:55Z = 11:18 PM AKDT. Exact lines from the run:
Four
pyshaclreports on the monolithic (closure-qc, metashacl, uco-qc, owl.ttl) each printed:I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes, or close it.