Require IRI nodeKind on configuration:itemObject - #696
Open
forest-savage1234 wants to merge 1 commit into
Open
Conversation
ConfigurationEntry.itemObject ranges over core:UcoObject, which must be IRI-identified. Change that property shape from BlankNodeOrIRI to IRI. Leave configurationEntry and dependencies alone. Closes ucoProject#663. Signed-off-by: Forest Savage <forestsavage03@gmail.com>
Author
|
Thank you for the time on this review. This only requires IRI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is a bug-fix change proposal, believed to be of low risk to the ontology and its downstream resources.
configuration:ConfigurationEntrycurrently letsitemObjectbe a blank node (sh:BlankNodeOrIRI). The range iscore:UcoObject, which must be IRI-identified. The shape becomessh:IRI.configurationEntryanddependenciesstaysh:BlankNodeOrIRI. Thesh:xoneitemObject vs itemValue split is untouched.Closes #663.
Out of scope
uco-core:Compilationshould upstream an in-commonsh:PropertyShapeforuco-core:object#662BlankNodeOrIRIshapes onConfiguration(configurationEntry,dependencies)sh:xoneitemObject vs itemValue splitOne token. Alex named this shape in #663. I am a volunteer; if blank-node objects are intentional, I will stand down.
Validation
make check(UCO CI)make --directory ontology/uco/configuration --file ../../../src/review.mk checkBoxes match commands actually run after the one token.
Box run 2026-08-22 11:19–11:36 PM AKDT on
/workspace/checkouts/UCOdevelop586ac690d9c9ca02ad3b9d94faf0b0a9dc91a615(586ac69 Merge pull request #688 from ucoProject/release-1.5.0). Working tree at run time: one token inontology/uco/configuration/configuration.ttlonly (itemObjectBlankNodeOrIRI→IRI).analysis.ttlwas reset to HEAD so this is not bundled with #694. Catalogs not in this packet. Python 3.13.5.A first
make checkstarted on this same tree at 11:21 PM AKDT exited 2 (rm: cannot remove '__uco_monolithic.ttl': No such file or directory/Makefile:104) because it raced anothermake checkin the same checkout. That failed run is not the checked box. The checkedmake checkis the completed independent run below (started 11:19 PM AKDT, EXIT:0, elapsed 1003192 ms, ended 2026-08-23T07:36:34Z = 11:36 PM AKDT).make --directory ontology/uco/configuration --file ../../../src/review.mk checkmake checkExact lines from the completed 663-only run.
git status --shortat start printedM ontology/uco/configuration/configuration.ttl.tests/inheritance_review.ttlaftercase_shacl_inheritance_reviewer --strict:Four
pyshaclreports on the monolithic (closure-qc, metashacl, uco-qc, owl.ttl) each printed:configuration_setting_PASS.json/configuration_setting_XFAIL.jsonran intests/examples(PASS fixture already uses an IRIitemObject). Final examples pytest:I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes, or close it.