Add additional shell, buffer, and application command types - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new
CommandType::Shell,CommandType::Buffer, andCommandType::Applicationvariants, which allow for additional command bar uses, primarily with the Kakoune, Emacs, and consumer application keybindings respectively.I've used
enum-mapto create a newCommandMaptype to make it easier for consumers to instantiate array-like mappings that contain already-initialized separate entries for everyCommandType, which I found helpful for simplifying the logic in bothRegisterStoreand inscansion.I haven't updated the Kakoune or Emacs keybindings yet to take advantage of
ShellandBufferrespectively. They'll both need new actions first that consume the register values.resolves #69
resolves #130