Skip to content

Add additional shell, buffer, and application command types - #235

Merged
ulyssa merged 1 commit into
mainfrom
ulyssa/command-types
Sep 26, 2026
Merged

ulyssa merged 1 commit into
mainfrom
ulyssa/command-types

Conversation

@ulyssa

@ulyssa ulyssa commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

This PR adds new CommandType::Shell, CommandType::Buffer, and CommandType::Application variants, which allow for additional command bar uses, primarily with the Kakoune, Emacs, and consumer application keybindings respectively.

I've used enum-map to create a new CommandMap type to make it easier for consumers to instantiate array-like mappings that contain already-initialized separate entries for every CommandType, which I found helpful for simplifying the logic in both RegisterStore and in scansion.

I haven't updated the Kakoune or Emacs keybindings yet to take advantage of Shell and Buffer respectively. They'll both need new actions first that consume the register values.

resolves #69
resolves #130

@ulyssa ulyssa added emacs Issues related to the Emacs keybindings kakoune Issues related to the Kakoune keybindings labels Sep 26, 2026
@ulyssa
ulyssa merged commit 25d03e2 into main Sep 26, 2026
4 checks passed
@ulyssa
ulyssa deleted the ulyssa/command-types branch September 26, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emacs Issues related to the Emacs keybindings kakoune Issues related to the Kakoune keybindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a CommandType::Shell variant Add a CommandType::Content variant

1 participant