Skip to content

feat: Document multi-arch builds - #269

Open
danielvallance wants to merge 1 commit into
prod-stagingfrom
danielvallance/multi_arch_builds
Open

feat: Document multi-arch builds#269
danielvallance wants to merge 1 commit into
prod-stagingfrom
danielvallance/multi_arch_builds

Conversation

@danielvallance

Copy link
Copy Markdown
Contributor

Closes: FIELD-787

@danielvallance
danielvallance temporarily deployed to pull-requests August 27, 2026 11:52 — with GitHub Actions Inactive
Comment thread pages/features/roms.mdx Outdated
Comment thread pages/features/roms.mdx Outdated
Comment thread pages/platform/images.mdx Outdated
Comment thread pages/tutorials/docker-to-ukc.mdx
@danielvallance
danielvallance requested review from jedevc and a balanced review from Copilot August 27, 2026 11:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents multi-architecture builds for x86_64, arm64, and ROM images.

Changes:

  • Adds architecture selection guidance.
  • Documents multi-architecture ROM builds.
  • Updates FAQ and tutorials for ARM support.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pages/tutorials/rootfs-volumes-roms.mdx Adds ROM target guidance.
pages/tutorials/docker-to-ukc.mdx Documents ARM build targets.
pages/platform/images.mdx Adds architecture configuration details.
pages/features/roms.mdx Adds architecture-aware ROM examples.
pages/faq.mdx Updates supported architecture information.
Suppressed comments (1)

pages/platform/images.mdx:138

  • These rows cover cases where only one selector is supplied, but the result says an architecture must be listed in both selectors. That incorrectly implies that --arch arm64 without targets selects nothing, contradicting the preceding explanation and the ROM guidance. Describe each selector independently and mention intersection only when both are present.
| `runtime` with `targets` or `--arch` | Only the architectures listed in both `targets` and `--arch`, which must be ones the runtime provides. |
| [`roms`](/features/roms) with no `runtime` | Only the architectures listed in both `targets` and `--arch`, and the build fails if neither are provided. |

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pages/platform/images.mdx

targets:
- kraftcloud/x86_64
- kraftcloud/arm64
@github-actions
github-actions Bot temporarily deployed to pull-requests August 27, 2026 11:56 Inactive
@danielvallance
danielvallance force-pushed the danielvallance/multi_arch_builds branch from 2bdea67 to 44c7e09 Compare August 27, 2026 12:02
@danielvallance
danielvallance temporarily deployed to pull-requests August 27, 2026 12:02 — with GitHub Actions Inactive
@github-actions
github-actions Bot temporarily deployed to pull-requests August 27, 2026 12:06 Inactive
@danielvallance
danielvallance requested a review from nurof3n August 28, 2026 16:03

@nurof3n nurof3n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread pages/platform/images.mdx Outdated
Comment thread pages/platform/images.mdx Outdated
Comment thread pages/platform/images.mdx Outdated
Comment thread pages/platform/images.mdx Outdated
Comment thread pages/platform/images.mdx Outdated
| [`roms`](/features/roms) with no `runtime` | Only the architectures listed in both `targets` and `--arch`, and the build fails if neither are provided. |

:::caution
Multi-platform builds need a correctly configured BuildKit builder on the host. Learn more [here](https://docs.docker.com/build/building/multi-platform/)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Unikraft.NoSentenceBreaks] Only use one sentence per line.

Comment thread pages/platform/images.mdx Outdated
Comment thread pages/platform/images.mdx Outdated
Comment thread pages/faq.mdx Outdated
Closes: FIELD-787

Signed-off-by: Daniel Vallance <daniel@unikraft.com>
@danielvallance
danielvallance force-pushed the danielvallance/multi_arch_builds branch from 59b50d1 to 7507ed6 Compare August 28, 2026 19:22

@nurof3n nurof3n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reviewed-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
Approved-by: Alex-Andrei Cioc andrei.cioc@unikraft.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants