Upgrade to mreg-api 0.5.0 - #471
Merged
Merged
Conversation
pederhan
marked this pull request as ready for review
August 31, 2026 15:24
pederhan
commented
Aug 31, 2026
Comment on lines
+47
to
+63
| @contextmanager | ||
| def strict_limit(client: MregClient) -> Generator[None, None, None]: | ||
| """Context manager that aborts requests for a query that returns too many results. | ||
|
|
||
| Adds a temporary mreg-api handler that listens for TRUNCATE events and | ||
| raises TooManyResults if such an event is received. | ||
| """ | ||
|
|
||
| def fail_on_truncate(event: Event) -> None: | ||
| if event.kind == EventKind.TRUNCATION: | ||
| raise TooManyResults(f"{event.message} Refine your search.") | ||
|
|
||
| client.events.subscribe(fail_on_truncate) | ||
| try: | ||
| yield | ||
| finally: | ||
| client.events.unsubscribe(fail_on_truncate) |
Member
Author
There was a problem hiding this comment.
This could be a general event listener we always have active instead of explicitly activated. Not sure what's best for this: implicit or explicit.
terjekv
approved these changes
Aug 31, 2026
terjekv
left a comment
terjekv
left a comment
Collaborator
There was a problem hiding this comment.
Not a huge fan of having to remember the context manager, but LGTM.
Member
Author
I will change it to an always-active rule. We only use limits in 2 places, so I don't think we'll accidentally trigger this exception if we enable it globally. I have another set of stashed changes ready, so I'll do it in that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes... Another set of breaking changes in mreg-api that requires a new minor version.
Main changes:
refresh()provides this functionality if necessary (only used inhost ttl_set).list()calls truncate results (len(results)> limit) via newstrict_limit()context manager.