Fix macOS compatibility (shall use spawn) - #2
Open
LuxxxLucy wants to merge 1 commit into
Open
Conversation
The start-method fallback treated all non-Windows platforms as fork. macOS defaults to spawn, so the spawn monkeypatch was skipped and child logs went to an orphan queue the listener never reads. Resolve the method per platform (spawn on Windows/macOS, fork on Linux) instead. Fixes unitreerobotics#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start-method fallback treated all non-Windows platforms as fork yet macOS shall defaults to spawn.
Resolve the method per platform accordingly (spawn on Windows/macOS, fork on Linux). As in README.md:
Fixes #1