fix(demo): auto-install demo deps in root dev script - #12
Merged
Conversation
The root `dev` script delegated to demo's vite without ensuring demo's dependencies were installed. A fresh clone + root `npm install` + `npm run dev` failed with "Cannot find package '@vitejs/plugin-react'" since demo is a separate npm project with its own lockfile. Prepend `npm --prefix demo install` (idempotent) so the demo starts without a separate manual install step. Closes #8
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8 — a fresh clone fails to start the demo with the root
devscript.The root
devscript delegated to the demo's vite (npm --prefix demo run dev) without ensuring the demo's dependencies were installed. Because the root anddemo/are separate npm projects (no workspaces;demo/has its ownpackage.json+ lockfile), a rootnpm installnever installs@vitejs/plugin-react— whichdemo/vite.config.tsimports at config-load time.Result on a fresh clone:
Fix
Prepend an idempotent install to the root
devscript:netlify-buildscript, which already runscd demo && npm installbefore building.The README and CONTRIBUTING docs already document
cd demo && npm install && npm run dev, so this change closes the gap for the root-leveldevscript specifically.Test plan
npm install(root) →npm run devstarts the demo without a separatecd demo && npm install.