chore(MVUX): update mvux sample to net 10 and latest Uno.Sdk#904
Open
DevTKSS wants to merge 8 commits into
Open
chore(MVUX): update mvux sample to net 10 and latest Uno.Sdk#904DevTKSS wants to merge 8 commits into
DevTKSS wants to merge 8 commits into
Conversation
…efresh Command docs xref will not work for users who might look up this Readme file, https will do. xref would only make sense if this file would be html rendered, which is not the case.
This Sample does not contain any Testing project, so we dont need those.
…gacy .EnableHotDesign
…nderer Feature The Project contains the Desktop target, so especially for a sample which should showcase running code, we should show the enhanced startup time and more fluent rendering.
…is has no migration advises and is potentially not longer supported. Awaiting Feedback if the complete folder for this platform has to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #887
PR Type:
What is the current behavior? 🤔
MainWindow.EnableHotDesign();Directory.Packages.propscontains Testing related Packages, but the Project itself does not use them - potentially still in there since the App has been created?Programm.csSkiaHostbuilder Type andUseWindows()outdated.slnhttpEntrySkiaRendererUnoFeatureWhat is the new behavior? 🚀
MainWindow.UseStudio();Directory.Packages.props- Removed Packages, this Solution doesn't even need external Packages not coverable from UnoFeaturesProgramm.csupdated to use UnoHostbuilder Type + added required namespaceUno.UI.Hostingand changed to.UseWin32()dotnet solution migrated to.slnxhttpEntry and addedSkiaRendererPR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️
Not sure if this is only a local or known issue, but as I was trying to build the Wasm target after Desktop succeeded flawlessly, the App gets stuck on the SplashScreen and thrown a
WebSocketException. I usually not use this target / Android also locally normal to be bugged all the time, I gave this up 🤷@Reviewer: Validation of Targets running needs to be done still!