fix: replace deprecated pyparsing oneOf/leaveWhitespace with snake_case equivalents - #36
Merged
Merged
Conversation
…se equivalents pyparsing emits PyparsingDeprecationWarning for oneOf() and .leaveWhitespace() under Python 3.11 with modern pyparsing releases. Switch to the one_of() and leave_whitespace() names to silence the warnings without changing behavior.
Member
|
We need to update our testing versions etc., but the tests pass locally, looks good to me. Thanks for updating this to get rid of the deprecation warnings @kwisatz ! |
Contributor
Author
|
I updated the tests, but I realized too late that you had already merged the PR without them being up to date. But I can see they're still failing on my side, I'll create another PR once they pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyparsing emits PyparsingDeprecationWarning for oneOf() and .leaveWhitespace() under Python 3.11 with modern pyparsing releases. Switch to the one_of() and leave_whitespace() names to silence the warnings without changing behavior.