Skip to content

Emit the app catalog's connector symbol at SF Symbols 6 too #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ryanmello07 merged 1 commit into from
Sep 9, 2026
Merged

Emit the app catalog's connector symbol at SF Symbols 6 too #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...sets.xcassets/ur.symbols.connector.fill.symbolset/ur.symbols.connector.fill.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 14 additions & 0 deletions app/widgets/Assets.xcassets/gen_connector_symbols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,20 @@
this software supports (6.0)" -- before it reads any of the artwork. The SF
Symbols app on a current machine exports 7.0, so if you re-export from it,
re-apply the 6.0 changes here rather than committing its output.

TWO CATALOGS carry these symbols and both are subject to that rule:

app/widgets/Assets.xcassets both symbols
app/network/Assets.xcassets ur.symbols.connector.fill only

Generating only the widgets catalog is how the 6.0 constraint was lost once
already: a later SF Symbols 7 export landed in app/network and broke every
build for a week, because nothing here owned that copy. Regenerate BOTH:

python3 gen_connector_symbols.py app/widgets/Assets.xcassets
python3 gen_connector_symbols.py /tmp/gen && \
cp /tmp/gen/ur.symbols.connector.fill.symbolset/* \
app/network/Assets.xcassets/ur.symbols.connector.fill.symbolset/
"""
import math
import os
Expand Down
Loading